[asterisk-dev] [Code Review] Support T.38 faxes on local channels

Matthew Nicholson mnicholson at digium.com
Wed Jul 28 14:36:13 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/813/
-----------------------------------------------------------

(Updated 2010-07-28 14:36:13.084211)


Review request for Asterisk Developers.


Changes
-------

Lock the pvt, the chan, and the bridged chan with fancy deadlock avoidance.  Please pay special attention to the deadlock avoidance code when reviewing.


Summary
-------

This patch enables asterisk to send T.38 faxes over local channels.  To accomplish this, support for ast_channel_queryoption() was added to chan_local and support for passing AST_CONTROL_T38_PARAMETERS control frames through a generic bridge was added.


Diffs (updated)
-----

  /trunk/channels/chan_local.c 280163 
  /trunk/main/channel.c 280163 

Diff: https://reviewboard.asterisk.org/r/813/diff


Testing
-------

I passed several T.38 faxes over a local channel bridged to a sip channel.


Thanks,

Matthew




More information about the asterisk-dev mailing list