[asterisk-dev] [Code Review] Support T.38 faxes on local channels

[Russell Bryant]

> On 2010-07-28 11:14:28, Russell Bryant wrote:
> > /trunk/channels/chan_local.c, lines 255-262
> > <https://reviewboard.asterisk.org/r/813/diff/2/?file=11955#file11955line255>
> >
> >     I don't think this is safe unless chan is locked before going into this part of the code.  ast_bridged_channel() could disappear out from under you as it is now.
> 
> Matthew Nicholson wrote:
>     Should I be locking chan and the bridged channel?

Yeah, I think you should lock bridged channel, as well.  It's going to be a nasty mess of deadlock avoidance in here.  :-(


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/813/#review2492
-----------------------------------------------------------


On 2010-07-28 12:14:15, Matthew Nicholson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/813/
> -----------------------------------------------------------
> 
> (Updated 2010-07-28 12:14:15)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch enables asterisk to send T.38 faxes over local channels.  To accomplish this, support for ast_channel_queryoption() was added to chan_local and support for passing AST_CONTROL_T38_PARAMETERS control frames through a generic bridge was added.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_local.c 278500 
>   /trunk/main/channel.c 278500 
> 
> Diff: https://reviewboard.asterisk.org/r/813/diff
> 
> 
> Testing
> -------
> 
> I passed several T.38 faxes over a local channel bridged to a sip channel.
> 
> 
> Thanks,
> 
> Matthew
> 
>