[asterisk-dev] [Code Review] Fix up sounds/Makefile some more.
Russell Bryant
russell at digium.com
Wed Jul 28 11:27:16 CDT 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/808/#review2494
-----------------------------------------------------------
Ship it!
This Makefile burns my eyes. If your tests are successful (and it fixes the reporter's problem), commit away.
- Russell
On 2010-07-27 14:05:06, Jason Parker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/808/
> -----------------------------------------------------------
>
> (Updated 2010-07-27 14:05:06)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> Removes unnecessary subshells. Attempts to make checksumming work (mantis issue 17621). Improve readability.
>
> These really couldn't be done separately.
>
>
> This addresses bug 17621.
> https://issues.asterisk.org/view.php?id=17621
>
>
> Diffs
> -----
>
> /branches/1.6.2/sounds/Makefile 279884
>
> Diff: https://reviewboard.asterisk.org/r/808/diff
>
>
> Testing
> -------
>
> Ran make install a bunch of different ways.
>
>
> Thanks,
>
> Jason
>
>
More information about the asterisk-dev
mailing list