[asterisk-dev] [Code Review] Top down test "one step parking" GSOC 2010

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/811/#review2493
-----------------------------------------------------------



/asterisk/trunk/tests/one-step-parking/run-test
<https://reviewboard.asterisk.org/r/811/#comment5498>

    Base the Asterisk instances in /tmp, not within the current directory.



/asterisk/trunk/tests/one-step-parking/run-test
<https://reviewboard.asterisk.org/r/811/#comment5499>

    There is now a cli_originate() function in the Asterisk class that you can use to simplify this.



/asterisk/trunk/tests/one-step-parking/run-test
<https://reviewboard.asterisk.org/r/811/#comment5500>

    Are there any cases where this might get called more than once?  I noticed that in your other test and added a safeguard against it.  Other tests have a similar check in them.



/asterisk/trunk/tests/one-step-parking/run-test
<https://reviewboard.asterisk.org/r/811/#comment5501>

    This will have already been done in read_result()


- Russell


On 2010-07-28 04:05:34, mnick wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/811/
> -----------------------------------------------------------
> 
> (Updated 2010-07-28 04:05:34)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> This is a "one step parking" top down test for asterisk:
> 
> userA calls userB
> userB parks userA by '*' - one step parking
> userB retrieves userA by calling 701
> - Test successful - 
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/one-step-parking/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/one-step-parking/configs/features.conf PRE-CREATION 
>   /asterisk/trunk/tests/one-step-parking/configs/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/one-step-parking/configs/logger.conf PRE-CREATION 
>   /asterisk/trunk/tests/one-step-parking/configs2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/one-step-parking/configs2/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/one-step-parking/configs2/logger.conf PRE-CREATION 
>   /asterisk/trunk/tests/one-step-parking/run-test PRE-CREATION 
>   /asterisk/trunk/tests/one-step-parking/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/tests.yaml 601 
> 
> Diff: https://reviewboard.asterisk.org/r/811/diff
> 
> 
> Testing
> -------
> 
> tested on 1.4, 1.6.0, 1.6.2 and trunk
> 
> 
> Thanks,
> 
> mnick
> 
>