[asterisk-dev] [Code Review] External test for fastagi.controlStreamFile()

Russell Bryant russell at digium.com
Wed Jul 28 10:54:27 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/801/#review2485
-----------------------------------------------------------

Ship it!


Don't forget to add it to tests/tests.yaml, too.  (After we get starpy upgraded on the test boxes, I suppose).

- Russell


On 2010-07-27 16:09:39, Erin Spiceland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/801/
> -----------------------------------------------------------
> 
> (Updated 2010-07-27 16:09:39)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> Self-explanatory. This test will always fail with StarPy 1.0.0a13 or older. Those versions expect Asterisk to send endpos, and Asterisk only sends it for STREAM FILE.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/fastagi/control-stream-file/run-test PRE-CREATION 
>   /asterisk/trunk/tests/fastagi/control-stream-file/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/801/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Erin
> 
>




More information about the asterisk-dev mailing list