[asterisk-dev] [Code Review] Add ability to use system libedit and update bundled libedit

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/807/#review2479
-----------------------------------------------------------

Ship it!


- Russell


On 2010-07-27 15:03:26, Sean Bright wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/807/
> -----------------------------------------------------------
> 
> (Updated 2010-07-27 15:03:26)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The version of libedit that is bundled with asterisk is old and has some bugs (see referenced issues 15929 and 16585).  This patch updates the bundled version of libedit within asterisk, and also updates asterisk to use the system libedit instead if one is available (and pkg-config is available).  This review integrates several patches from other users specifically kkm and tzafrir.
> 
> The version of libedit bundled with asterisk is now an svn:external from http://svn.digium.com/svn/thirdparty/editline/trunk and is not included in the diff.
> 
> 
> This addresses bugs 15929, 16858 and 17039.
>     https://issues.asterisk.org/view.php?id=15929
>     https://issues.asterisk.org/view.php?id=16858
>     https://issues.asterisk.org/view.php?id=17039
> 
> 
> Diffs
> -----
> 
>   /trunk/build_tools/menuselect-deps.in 279885 
>   /trunk/configure.ac 279885 
>   /trunk/include/asterisk/autoconfig.h.in 279885 
>   /trunk/include/asterisk/term.h 279885 
>   /trunk/main/Makefile 279885 
>   /trunk/main/asterisk.c 279885 
>   /trunk/main/cli.c 279885 
>   /trunk/main/term.c 279885 
>   /trunk/main/xmldoc.c 279885 
>   /trunk/makeopts.in 279885 
> 
> Diff: https://reviewboard.asterisk.org/r/807/diff
> 
> 
> Testing
> -------
> 
> * Compiles with the external and internal libedit libraries on my system
> * Asterisk runs and the CLI behaves normally when running commands and accessing history
> 
> 
> Thanks,
> 
> Sean
> 
>