[asterisk-dev] [Code Review] External test for fastagi.controlStreamFile()

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/801/#review2477
-----------------------------------------------------------



/asterisk/trunk/tests/fastagi/control-stream-file/run-test
<https://reviewboard.asterisk.org/r/801/#comment5465>

    It would be nice to name the base directory differently for each test.  That way it's easier to go back and find the right logs if needed.



/asterisk/trunk/tests/fastagi/control-stream-file/run-test
<https://reviewboard.asterisk.org/r/801/#comment5466>

    It's safe to assume that the core sounds package is installed.  Maybe something should just be played from there instead of including a sound in the testsuite repo?


- Russell


On 2010-07-26 15:40:49, Erin Spiceland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/801/
> -----------------------------------------------------------
> 
> (Updated 2010-07-26 15:40:49)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> Self-explanatory. This test will always fail with StarPy 1.0.0a13 or older. Those versions expect Asterisk to send endpos, and Asterisk only sends it for STREAM FILE.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/fastagi/control-stream-file/run-test PRE-CREATION 
>   /asterisk/trunk/tests/fastagi/control-stream-file/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/801/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Erin
> 
>