[asterisk-dev] [asterisk-commits] pabelanger: branch 1.8 r279566 - in /branches/1.8: ./ configs/

[Kevin P. Fleming]

On 07/26/2010 02:51 PM, SVN commits to the Asterisk project wrote:
> Author: pabelanger
> Date: Mon Jul 26 14:51:39 2010
> New Revision: 279566
> 
> URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=279566
> Log:
> Add documentation for FAX logger level.
> 
> (closes issue #17715)
> Reported by: vrban
> Patches:
>       17715.patch uploaded by pabelanger (license 224)
> Tested by: vrban
> 
> Modified:
>     branches/1.8/CHANGES
>     branches/1.8/UPGRADE.txt
>     branches/1.8/configs/logger.conf.sample
> 
> Modified: branches/1.8/CHANGES
> URL: http://svnview.digium.com/svn/asterisk/branches/1.8/CHANGES?view=diff&rev=279566&r1=279565&r2=279566
> ==============================================================================
> --- branches/1.8/CHANGES (original)
> +++ branches/1.8/CHANGES Mon Jul 26 14:51:39 2010
> @@ -484,6 +484,8 @@
>   * A spandsp based fax backend (res_fax_spandsp) has been added.
>   * The app_fax module has been deprecated in favor of the res_fax module and
>     the new res_fax_spandsp backend.
> + * A new FAX logger level has been created for spandsp replacing the DEBUG logger
> +   level. The logger.conf.sample file has been update to include an example. 

This is really not a good way to describe this change; users of SendFAX
and ReceiveFAX are going to be searching for those application names in
this file when they can't find their logging output, not 'spandsp'. I
would suggest:

The SendFAX and ReceiveFAX applications now send their log messages to a
'fax' logger level, instead of to the generic logger levels. To see
these messages, the system's logger.conf file will need to direct the
'fax' logger level to one or more destinations; the logger.conf.sample
file includes an example of how to do this. Note that if the 'fax'
logger level is *not* directed to at least one destination, log
messages generated by these applications will be lost, and that if
the 'fax' logger level is directed to the console, the 'core set
verbose' and 'core set debug' CLI commands will have no effect on
whether the messages appear on the console or not.

>  
>  Miscellaneous
>  -------------
> 
> Modified: branches/1.8/UPGRADE.txt
> URL: http://svnview.digium.com/svn/asterisk/branches/1.8/UPGRADE.txt?view=diff&rev=279566&r1=279565&r2=279566
> ==============================================================================
> --- branches/1.8/UPGRADE.txt (original)
> +++ branches/1.8/UPGRADE.txt Mon Jul 26 14:51:39 2010
> @@ -105,6 +105,9 @@
>  * chan_sip will no longer set up a local call forward when receiving a
>    482 Loop Detected response. The dialplan will just continue from where it
>    left off.
> +
> +* All fax-related messages from spandsp, that previously went to DEBUG logger
> +  level, will now be logged to a FAX logger if possible.

Use the same text as above for CHANGES, or just put it only in UPGRADE,
not in both places.

-- 
Kevin P. Fleming
Digium, Inc. | Director of Software Technologies
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
skype: kpfleming | jabber: kfleming at digium.com
Check us out at www.digium.com & www.asterisk.org