[asterisk-dev] [Code Review] New SIP tests to exercise IPv6 support

[Mark Michelson]

> On 2010-07-23 04:55:47, Russell Bryant wrote:
> > /asterisk/trunk/tests/sip_register/run-test, lines 97-103
> > <https://reviewboard.asterisk.org/r/796/diff/4/?file=11843#file11843line97>
> >
> >     If you change self.sipps to a dictionary keyed on peer, then you would iterate it by doing:
> >     
> >     for peer, i in self.sipps:
> >        pass

I ended up using 

for peer, i in self.sipps.iteritems() since that's what I found documentation for on-line.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/796/#review2455
-----------------------------------------------------------


On 2010-07-22 10:15:42, Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/796/
> -----------------------------------------------------------
> 
> (Updated 2010-07-22 10:15:42)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Five new tests:
> 
> 1. sip_attended_transfer_v6. Identical to sip_attended_transfer except it uses IPv6 addresses.
> 2. sip_one_legged_transfer_v6. Identical to sip_one_leggeed_transfer except it uses IPv6 addresses.
> 3. sip_register. An IPv4 and IPv6 SIPp client register with Asterisk.
> 4. udptl. One instance of Asterisk sends a T.38 FAX to another instance of Asterisk.
> 5. udptl_v6. Same as udptl except IPv6 addresses are used.
> 
> In addition, the README file has been updated with instructions on how to enabled IPv6 support in pjsua. Also, a custom dependency for IPv6-capable pjsua has been added to runtests.py.
> 
> This is my first time writing tests in python, so let me know if I'm doing anything the hard way and I'll be an eager learner.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/README.txt 545 
>   /asterisk/trunk/runtests.py 545 
>   /asterisk/trunk/tests/sip_attended_transfer_v6/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/sip_attended_transfer_v6/configs/manager.conf PRE-CREATION 
>   /asterisk/trunk/tests/sip_attended_transfer_v6/configs/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/sip_attended_transfer_v6/run-test PRE-CREATION 
>   /asterisk/trunk/tests/sip_attended_transfer_v6/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/sip_one_legged_transfer_v6/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/sip_one_legged_transfer_v6/configs/manager.conf PRE-CREATION 
>   /asterisk/trunk/tests/sip_one_legged_transfer_v6/configs/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/sip_one_legged_transfer_v6/run-test PRE-CREATION 
>   /asterisk/trunk/tests/sip_one_legged_transfer_v6/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/sip_register/configs/manager.conf PRE-CREATION 
>   /asterisk/trunk/tests/sip_register/configs/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/sip_register/run-test PRE-CREATION 
>   /asterisk/trunk/tests/sip_register/sipp/registerv4.xml PRE-CREATION 
>   /asterisk/trunk/tests/sip_register/sipp/registerv6.xml PRE-CREATION 
>   /asterisk/trunk/tests/sip_register/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/tests.yaml 545 
>   /asterisk/trunk/tests/udptl/1page.tif UNKNOWN 
>   /asterisk/trunk/tests/udptl/configs1/logger.conf PRE-CREATION 
>   /asterisk/trunk/tests/udptl/configs1/manager.conf PRE-CREATION 
>   /asterisk/trunk/tests/udptl/configs1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/udptl/configs2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/udptl/configs2/logger.conf PRE-CREATION 
>   /asterisk/trunk/tests/udptl/configs2/manager.conf PRE-CREATION 
>   /asterisk/trunk/tests/udptl/configs2/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/udptl/run-test PRE-CREATION 
>   /asterisk/trunk/tests/udptl/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/udptl_v6/1page.tif UNKNOWN 
>   /asterisk/trunk/tests/udptl_v6/configs1/logger.conf PRE-CREATION 
>   /asterisk/trunk/tests/udptl_v6/configs1/manager.conf PRE-CREATION 
>   /asterisk/trunk/tests/udptl_v6/configs1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/udptl_v6/configs2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/udptl_v6/configs2/logger.conf PRE-CREATION 
>   /asterisk/trunk/tests/udptl_v6/configs2/manager.conf PRE-CREATION 
>   /asterisk/trunk/tests/udptl_v6/configs2/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/udptl_v6/run-test PRE-CREATION 
>   /asterisk/trunk/tests/udptl_v6/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/796/diff
> 
> 
> Testing
> -------
> 
> All tests pass against trunk, except for udptl_v6, since trunk does not currently support IPv6 addresses with UDPTL streams. That test does pass when paired with the diff in review 795, though.
> 
> 
> Thanks,
> 
> Mark
> 
>