[asterisk-dev] [Code Review] Makefile clean-up

Tzafrir Cohen tzafrir.cohen at xorcom.com
Fri Jul 23 05:30:11 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/654/#review2457
-----------------------------------------------------------



/trunk/Makefile
<https://reviewboard.asterisk.org/r/654/#comment5402>

    This removes quotes from the target dir.
    
    Looks like they were added for the sake of someone using OSX (r262852). Is it OK to remove them?


- Tzafrir


On 2010-07-16 17:57:16, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/654/
> -----------------------------------------------------------
> 
> (Updated 2010-07-16 17:57:16)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Various changes to Makefile, prefer install over mkdir, mv, chmod and chgrp.
> 
> Preface for unprivileged installations.
> 
> 
> Diffs
> -----
> 
>   /trunk/Makefile 276612 
>   /trunk/agi/Makefile 276612 
>   /trunk/sounds/Makefile 276612 
> 
> Diff: https://reviewboard.asterisk.org/r/654/diff
> 
> 
> Testing
> -------
> 
> Much more testing required. Only tested with Ubuntu.
> 
> 
> Thanks,
> 
> pabelanger
> 
>




More information about the asterisk-dev mailing list