[asterisk-dev] [Code Review] SIP URI comparison test (plus some bug fixes)

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/792/
-----------------------------------------------------------

(Updated 2010-07-20 11:01:33.723667)


Review request for Asterisk Developers and Olle E Johansson.


Changes
-------

This addresses several comments made by reviewers:

* Dumped usage of XOR in favor of !=
* Use locale-specific string comparison for hostnames.
* Add additional checks to be sure that we don't try to operate on NULL strings in sip_uri_cmp()
* Use ast_test_status_update if there is a test failure.
* Added reference to the IETF draft Simon linked in the sip_uri_domain_cmp() doxygen
* Added various test cases:
    - Identical IPv4 addresses with different representations
    - IPv4 address and same logical hostname
    - IPv6 address and same logical hostname
    - Several malformed URIs to ensure no crash occurs more than anything
    - Same parameters and values in URIs but appearing in a different order

There are still some malformed URIs that will not be detected, like "sip:bob at example@example" We currently don't attempt to ensure any reserved characters are not used in places they are not allowed.


Summary
-------

Issue 17662 was opened by oej since he discovered that using a string comparison for domains was not a viable solution since IPv6 addresses may be represented in many different ways, all of which are considered to be the same address. The patch attached on that issue was my initial attempt at solving the issue.

While I was dabbling in the area, I felt it would be a good idea to add a SIP URI comparison internal test to be sure that all the logic was correct. What I found was that in many regards, the comparison of URI parameters was not working as it should be. That being the case, I largely rewrote the logic of sip_uri_params_cmp() to work correctly.

All SIP URI comparison code has been moved to channels/sip/reqresp_parser.c, including the new test. If you have good ideas for test cases that I haven't thought of yet, please feel free to add comments to the review request.

Also of note, the bugs I found in sip_uri_params_cmp() affect 1.4 and 1.6.2 as well. My plan is to backport the bugfixes to those branches as well once I get a "Ship it!" on this review.


This addresses bug 17662.
    https://issues.asterisk.org/view.php?id=17662


Diffs (updated)
-----

  /trunk/channels/chan_sip.c 277873 
  /trunk/channels/sip/include/reqresp_parser.h 277813 
  /trunk/channels/sip/reqresp_parser.c 277813 

Diff: https://reviewboard.asterisk.org/r/792/diff


Testing
-------

The new set of tests passes.


Thanks,

Mark