[asterisk-dev] [Code Review] Remove built-in AES code from trunk in favor of using the optional api
Terry Wilson
twilson at digium.com
Mon Jul 19 22:37:50 CDT 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/793/
-----------------------------------------------------------
(Updated 2010-07-19 22:37:50.039576)
Review request for Asterisk Developers.
Changes
-------
Fix doc spelling error
Summary
-------
Remove built-in AES code and use the optional_api with the OpenSSL AES implementation.
Diffs (updated)
-----
/trunk/channels/chan_iax2.c 277905
/trunk/channels/iax2-parser.h 277905
/trunk/funcs/func_aes.c 277905
/trunk/include/asterisk/aes.h 277905
/trunk/include/asterisk/aes_internal.h 277905
/trunk/include/asterisk/crypto.h 277905
/trunk/main/aescrypt.c 277905
/trunk/main/aeskey.c 277905
/trunk/main/aesopt.h 277905
/trunk/main/aestab.c 277905
/trunk/pbx/dundi-parser.h 277905
/trunk/pbx/pbx_dundi.c 277905
/trunk/res/res_crypto.c 277905
/trunk/res/res_crypto.exports.in 277905
Diff: https://reviewboard.asterisk.org/r/793/diff
Testing
-------
I have tested using func_aes with res_crypto loaded and unloaded. A warning is produced w/o res_crypto loaded and no encryption done. Encryption/Decryption works when res_crypto is loaded.
Thanks,
Terry
More information about the asterisk-dev
mailing list