[asterisk-dev] [Code Review] [regression] T.38 negotiation Broken

[Matthew Nicholson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/754/#review2417
-----------------------------------------------------------

Ship it!


This looks good.

- Matthew


On 2010-06-29 12:58:53, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/754/
> -----------------------------------------------------------
> 
> (Updated 2010-06-29 12:58:53)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Moving to reviewboard from tracker.  This was marked as a regression.
> 
> ---
> After upgrading from 1.4.26.3 to 1.4.29 the T.38 negoation seems broken. Probably this issue is a replication of 0016318 . Unfortunatly on the 1.4.29 it's look like the issue it's not totally fixed.
> I try to send a fax from an ATA to a fan on analog line.
> ATA -> Asterisk -> Patton SN4091
> 
> When the fax answer the asterisk don't handle properly the call, on the CLI I can see the message "Start music on hold" link with the ATA sip channel.
> 
> As attachment the log of the console 
> 
> 
> This addresses bug 16705.
>     https://issues.asterisk.org/view.php?id=16705
> 
> 
> Diffs
> -----
> 
>   branches/1.4/channels/chan_sip.c 244689 
> 
> Diff: https://reviewboard.asterisk.org/r/754/diff
> 
> 
> Testing
> -------
> 
> Reporters on tracker report success with patch.
> 
> 
> Thanks,
> 
> pabelanger
> 
>