[asterisk-dev] [Code Review] GSoC2010: the ast_storage public API and the part of the odbc storage backend
paul.belanger at polybeacon.com
paul.belanger at polybeacon.com
Fri Jul 16 18:15:53 CDT 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/773/#review2415
-----------------------------------------------------------
Simple peer review for CODING GUIDELINES.
/team/ivaxer/ast_storage/include/asterisk/storage.h
<https://reviewboard.asterisk.org/r/773/#comment5305>
2010
/team/ivaxer/ast_storage/main/file.c
<https://reviewboard.asterisk.org/r/773/#comment5306>
braces since we are here.
/team/ivaxer/ast_storage/main/file.c
<https://reviewboard.asterisk.org/r/773/#comment5307>
same as above
/team/ivaxer/ast_storage/main/storage.c
<https://reviewboard.asterisk.org/r/773/#comment5308>
2010
/team/ivaxer/ast_storage/main/storage.c
<https://reviewboard.asterisk.org/r/773/#comment5309>
blob
/team/ivaxer/ast_storage/main/storage.c
<https://reviewboard.asterisk.org/r/773/#comment5310>
blob
/team/ivaxer/ast_storage/main/storage.c
<https://reviewboard.asterisk.org/r/773/#comment5311>
move { to next line.
/team/ivaxer/ast_storage/main/storage.c
<https://reviewboard.asterisk.org/r/773/#comment5312>
same
/team/ivaxer/ast_storage/main/storage.c
<https://reviewboard.asterisk.org/r/773/#comment5313>
same
/team/ivaxer/ast_storage/main/storage.c
<https://reviewboard.asterisk.org/r/773/#comment5314>
braces
/team/ivaxer/ast_storage/main/storage.c
<https://reviewboard.asterisk.org/r/773/#comment5315>
same as above
/team/ivaxer/ast_storage/main/storage.c
<https://reviewboard.asterisk.org/r/773/#comment5316>
braces
/team/ivaxer/ast_storage/main/storage.c
<https://reviewboard.asterisk.org/r/773/#comment5317>
braces
/team/ivaxer/ast_storage/main/storage.c
<https://reviewboard.asterisk.org/r/773/#comment5318>
same
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5319>
2010
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5320>
blob
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5321>
braces
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5322>
move { to next line
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5323>
space between if and (
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5324>
same as above
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5325>
same
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5326>
same
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5327>
space
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5328>
move { to next line.
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5329>
braces
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5330>
blob
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5331>
} else {
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5332>
{ next line
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5333>
remove extra white space
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5334>
spacing
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5335>
same as above
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5336>
spacing
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5337>
space
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5338>
space
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5339>
same
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5340>
same
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5341>
same
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5342>
same
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5343>
same
/team/ivaxer/ast_storage/res/res_storage_odbc.c
<https://reviewboard.asterisk.org/r/773/#comment5344>
same
- pabelanger
On 2010-07-13 13:41:57, ivaxer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/773/
> -----------------------------------------------------------
>
> (Updated 2010-07-13 13:41:57)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> implemented the the public API functions and the main odbc storage backend functions (create/release/get/put).
>
>
> Diffs
> -----
>
> /team/ivaxer/ast_storage/include/asterisk/file.h 262099
> /team/ivaxer/ast_storage/include/asterisk/storage.h PRE-CREATION
> /team/ivaxer/ast_storage/main/asterisk.c 262099
> /team/ivaxer/ast_storage/main/file.c 262099
> /team/ivaxer/ast_storage/main/storage.c PRE-CREATION
> /team/ivaxer/ast_storage/res/res_storage_odbc.c PRE-CREATION
>
> Diff: https://reviewboard.asterisk.org/r/773/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> ivaxer
>
>
More information about the asterisk-dev
mailing list