[asterisk-dev] [Code Review] non-root install for Asterisk

[Tzafrir Cohen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/654/#review2390
-----------------------------------------------------------



/trunk/sounds/Makefile
<https://reviewboard.asterisk.org/r/654/#comment5275>

    You can simplify those two:
    
    if [ "$(AST_USER)" != "" ] ; then
    	chown -R $(AST_USER):$(AST_GROUP) $(SOUNDS_DIR)
    	chown -R $(AST_USER):$(AST_GROUP) $(MOH_DIR)
    fi
    
    'chown $someuser: file' sets the group of that file to the default group of that user.



/trunk/configure.ac
<https://reviewboard.asterisk.org/r/654/#comment5281>

    This is not the right test.
    
    * Does not check the exact column
    * Does not check an exact name.
    
    Use:  '^{ast_user}:'
    
    * The user may actually not be a local user. Use 'getent passwd '${ast_user}'


- Tzafrir


On 2010-07-14 23:56:00, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/654/
> -----------------------------------------------------------
> 
> (Updated 2010-07-14 23:56:00)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Make Asterisk install as non-root, this is now the default behavior.
> 
> 3 new configure options:
> --with-user=uid
> --with-group=gid
> --enable-root
> 
> Various changes to Makefile, prefer install over mkdir, mv, chmod and chgrp.
> 
> 
> Diffs
> -----
> 
>   /trunk/Makefile 276612 
>   /trunk/Makefile.moddir_rules 276612 
>   /trunk/agi/Makefile 276612 
>   /trunk/configure.ac 276612 
>   /trunk/include/asterisk/autoconfig.h.in 276612 
>   /trunk/makeopts.in 276612 
>   /trunk/sounds/Makefile 276612 
> 
> Diff: https://reviewboard.asterisk.org/r/654/diff
> 
> 
> Testing
> -------
> 
> Much more testing required. Only tested with Ubuntu.
> 
> 
> Thanks,
> 
> pabelanger
> 
>