[asterisk-dev] [Code Review] non-root install for Asterisk

[paul.belanger at polybeacon.com]

> On 2010-07-14 22:32:25, Tilghman Lesher wrote:
> > /trunk/configure.ac, lines 500-507
> > <https://reviewboard.asterisk.org/r/654/diff/5/?file=11593#file11593line500>
> >
> >     This is a double-negative, which is confusing.  If we say that non-root is the default, then the opposite should be "--enable-root", not "--disable-non-root".  Besides, "--disable-non-root" is a misnomer; it's not ACTUALLY disabling running Asterisk as non-root; it's merely allowing Asterisk to run as root.  Thus "--enable-root" is a much better phrase to use.

Agree.  Cleaning up now.


- pabelanger


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/654/#review2394
-----------------------------------------------------------


On 2010-07-14 20:47:22, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/654/
> -----------------------------------------------------------
> 
> (Updated 2010-07-14 20:47:22)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Make Asterisk install as non-root, this is now the default behavior.
> 
> 3 new configure options:
> --with-user=uid
> --with-group=gid
> --disable-non-root
> 
> Various changes to Makefile, prefer install over mkdir, mv, chmod and chgrp.
> 
> 
> Diffs
> -----
> 
>   /trunk/Makefile 276612 
>   /trunk/Makefile.moddir_rules 276612 
>   /trunk/agi/Makefile 276612 
>   /trunk/configure.ac 276612 
>   /trunk/include/asterisk/autoconfig.h.in 276612 
>   /trunk/makeopts.in 276612 
>   /trunk/sounds/Makefile 276612 
> 
> Diff: https://reviewboard.asterisk.org/r/654/diff
> 
> 
> Testing
> -------
> 
> Much more testing required. Only tested with Ubuntu.
> 
> 
> Thanks,
> 
> pabelanger
> 
>