[asterisk-dev] [Code Review] Fix documentation for pgsql cel and cdr, slightly improve pgsql_cel

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/734/#review2387
-----------------------------------------------------------

Ship it!


- Russell


On 2010-06-21 19:21:24, tim_ringenbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/734/
> -----------------------------------------------------------
> 
> (Updated 2010-06-21 19:21:24)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I went to test out cel and noticed the documentation use "time" instead of "timestamp" to store the timestamp, which meant that it would only store the time and not the date of the event. The cdr docs were doing the same thing.
> 
> Then I noticed some columns were missing, and some were spelled wrong and weren't logging.
> So I fixed that, and I updated the size of the uniqueid to be the same as the cdr.
> I also added an id column of type serial and patched the driver so that it asks postgresql to put the default value in columns it doesn't know about instead of 0 or the empty string.
> 
> Finally, I added the microseconds to the timestamp.
> 
> 
> Diffs
> -----
> 
>   http://svn.asterisk.org/svn/asterisk/trunk/cel/cel_pgsql.c 271657 
>   http://svn.asterisk.org/svn/asterisk/trunk/doc/tex/cdrdriver.tex 271657 
>   http://svn.asterisk.org/svn/asterisk/trunk/doc/tex/celdriver.tex 271657 
> 
> Diff: https://reviewboard.asterisk.org/r/734/diff
> 
> 
> Testing
> -------
> 
> I made some calls and saw that the events logged to my postgresql database.
> 
> 
> Thanks,
> 
> tim_ringenbach
> 
>