[asterisk-dev] [Code Review] SIP from-header is parsed twice

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/701/#review2382
-----------------------------------------------------------


Sorry I was not able to follow up on this quickly.  So many things have gone into chan_sip over the past 2 weeks this patch doesn't apply cleanly anymore.  If you can update the patch and take a look at my comments I'll test it and hopefully get this committed.


trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/701/#comment5265>

    I get a compile error here on the 7th argument.



trunk/channels/sip/reqresp_parser.c
<https://reviewboard.asterisk.org/r/701/#comment5266>

    I know this code was here before this patch, but it seems like if we are going to skip over the semicolon here, we should check to make sure it is a semicolon first.


- David


On 2010-06-22 08:57:10, Nick Lewis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/701/
> -----------------------------------------------------------
> 
> (Updated 2010-06-22 08:57:10)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> The handlers in chan_sip.c for invite and subscription requests parse the from-header twice. The first time is in check_user_full and the second time is in get_destination. This change removes the parsing from these functions and does it beforehand (with an abnf compliant parser)
> 
> 
> This addresses bug 16897.
>     https://issues.asterisk.org/view.php?id=16897
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 268968 
>   trunk/channels/sip/reqresp_parser.c 268968 
> 
> Diff: https://reviewboard.asterisk.org/r/701/diff
> 
> 
> Testing
> -------
> 
> Compiles, runs, passes associated unit test. CID field appears correct in sip show channel 
> 
> 
> Thanks,
> 
> Nick
> 
>