[asterisk-dev] [Code Review] Expand the caller ANI field to an ast_party_id

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/744/#review2377
-----------------------------------------------------------

Ship it!


- Russell


On 2010-06-24 16:22:07, rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/744/
> -----------------------------------------------------------
> 
> (Updated 2010-06-24 16:22:07)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Summary
> -------
> 
> Expand the ani field in ast_party_caller and ast_party_connected_line to
> an ast_party_id.
> 
> This is an extension to the ast_callerid restructuring patch in review:
> https://reviewboard.asterisk.org/r/702/
> 
> Note that the "XXX_" prepended to the name and number members in
> ast_party_id in the diff are to ensure that all code has been converted
> and will be renamed when committed.
> 
> 
> Diffs
> -----
> 
>   /team/rmudgett/cid/apps/app_amd.c 272445 
>   /team/rmudgett/cid/channels/chan_dahdi.c 272445 
>   /team/rmudgett/cid/channels/chan_h323.c 272445 
>   /team/rmudgett/cid/channels/chan_iax2.c 272445 
>   /team/rmudgett/cid/channels/chan_jingle.c 272445 
>   /team/rmudgett/cid/channels/chan_mgcp.c 272445 
>   /team/rmudgett/cid/channels/chan_misdn.c 272445 
>   /team/rmudgett/cid/channels/chan_oss.c 272445 
>   /team/rmudgett/cid/channels/chan_phone.c 272445 
>   /team/rmudgett/cid/channels/chan_sip.c 272445 
>   /team/rmudgett/cid/channels/chan_skinny.c 272445 
>   /team/rmudgett/cid/channels/chan_usbradio.c 272445 
>   /team/rmudgett/cid/channels/chan_vpb.cc 272445 
>   /team/rmudgett/cid/channels/sig_analog.c 272445 
>   /team/rmudgett/cid/channels/sig_pri.c 272445 
>   /team/rmudgett/cid/channels/sig_ss7.c 272445 
>   /team/rmudgett/cid/funcs/func_callerid.c 272445 
>   /team/rmudgett/cid/include/asterisk/channel.h 272445 
>   /team/rmudgett/cid/main/cdr.c 272445 
>   /team/rmudgett/cid/main/cel.c 272445 
>   /team/rmudgett/cid/main/channel.c 272445 
>   /team/rmudgett/cid/res/snmp/agent.c 272445 
> 
> Diff: https://reviewboard.asterisk.org/r/744/diff
> 
> 
> Testing
> -------
> 
> Compile testing.  SIP and ISDN Q.SIG calls with CALLERID(ANI-xxx) values set and read.
> 
> 
> Thanks,
> 
> rmudgett
> 
>