[asterisk-dev] [Code Review] non-root install for Asterisk

[paul.belanger at polybeacon.com]

> On 2010-07-12 18:12:24, Tilghman Lesher wrote:
> > I'd say you need to test this with Solaris and FreeBSD, at the very minimum, given how far these changes go.

Agree.  I'll be attempting to round up some testers.


> On 2010-07-12 18:12:24, Tilghman Lesher wrote:
> > /trunk/Makefile, line 722
> > <https://reviewboard.asterisk.org/r/654/diff/4/?file=11537#file11537line722>
> >
> >     What was the reason for this swap?

I swapped because installdirs: depends on bininstall:.  I moved some mkdir commands out of datafiles:, making datafile now depend on installdirs:.


> On 2010-07-12 18:12:24, Tilghman Lesher wrote:
> > /trunk/configure.ac, line 502
> > <https://reviewboard.asterisk.org/r/654/diff/4/?file=11540#file11540line502>
> >
> >     "Explicitly"

Fixed


> On 2010-07-12 18:12:24, Tilghman Lesher wrote:
> > /trunk/configure.ac, lines 515-516
> > <https://reviewboard.asterisk.org/r/654/diff/4/?file=11540#file11540line515>
> >
> >     Won't this set astuser and astgroup to the ENTIRE line inside /etc/passwd and /etc/group, respectively?  Do you really want anything more than just a 'grep -c'?

Will review the code.


> On 2010-07-12 18:12:24, Tilghman Lesher wrote:
> > /trunk/res/res_timing_kqueue.c, lines 22-24
> > <https://reviewboard.asterisk.org/r/654/diff/4/?file=11543#file11543line22>
> >
> >     Uh, why are you deleting res_timing_kqueue?

looks like a bad merge, to be restored.


> On 2010-07-12 18:12:24, Tilghman Lesher wrote:
> > /trunk/Makefile, lines 566-575
> > <https://reviewboard.asterisk.org/r/654/diff/4/?file=11537#file11537line566>
> >
> >     Could you be more explicit about what the benefit of using install is here?  Frankly, I don't see the point of checking whether the directory exists first; it appears that install already does that check by itself.

I figured it would help _clean_ up the install.  From what I was seeing $(INSTALL) would attempt the re-create the directory everytime you installed. I just added this logic today.  I'll review the possible benefits / downsides.


- pabelanger


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/654/#review2370
-----------------------------------------------------------


On 2010-07-12 16:22:42, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/654/
> -----------------------------------------------------------
> 
> (Updated 2010-07-12 16:22:42)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Make Asterisk install as non-root, this is now the default behavior.
> 
> 3 new configure options:
> --with-user=uid
> --with-group=gid
> --disable-non-root
> 
> Various changes to Makefile, prefer install over mkdir, mv, chmod and chgrp.
> 
> 
> Diffs
> -----
> 
>   /trunk/Makefile 275776 
>   /trunk/Makefile.moddir_rules 275776 
>   /trunk/agi/Makefile 275776 
>   /trunk/configure.ac 275776 
>   /trunk/include/asterisk/autoconfig.h.in 275776 
>   /trunk/makeopts.in 275776 
>   /trunk/res/res_timing_kqueue.c 275776 
>   /trunk/sounds/Makefile 275776 
> 
> Diff: https://reviewboard.asterisk.org/r/654/diff
> 
> 
> Testing
> -------
> 
> Much more testing required. Only tested with Ubuntu.
> 
> 
> Thanks,
> 
> pabelanger
> 
>