[asterisk-dev] [Code Review] Add sample script for externpasscheck option in voicemail.conf

[Russell Bryant]

> On 2010-07-12 11:53:16, Leif Madsen wrote:
> > /trunk/contrib/scripts/voicemailpwcheck.py, line 24
> > <https://reviewboard.asterisk.org/r/774/diff/3/?file=11518#file11518line24>
> >
> >     I guess you should change '6' to REQUIRED_LENGTH?

Good call.  done.


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/774/#review2364
-----------------------------------------------------------


On 2010-07-12 11:45:10, Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/774/
> -----------------------------------------------------------
> 
> (Updated 2010-07-12 11:45:10)
> 
> 
> Review request for Asterisk Developers and leifmadsen.
> 
> 
> Summary
> -------
> 
> While working on some documentation this morning, I came up with a sample script for use with the externpasscheck option.  I also updated the sample configuration file to document how the script passes back a result to Asterisk.
> 
> 
> This addresses bug 17628.
>     https://issues.asterisk.org/view.php?id=17628
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/voicemail.conf.sample 275586 
>   /trunk/contrib/scripts/voicemailpwcheck.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/774/diff
> 
> 
> Testing
> -------
> 
> Leif tested a number of password change attempts, both valid and invalid, and the VoicemailMain() application responded as we would expect.
> 
> 
> Thanks,
> 
> Russell
> 
>