[asterisk-dev] [Code Review] Top down test "blind transfer with parking timeout" GSOC 2010

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/762/#review2361
-----------------------------------------------------------

Ship it!


This looks good to me.  Feel free to commit it to the test suite.

The only suggestion I have for potential future improvement is to think about other ways to end the test instead of having to wait the full 60 second period.  It would be nice if there was something that could detect when the test has finished successfully and end early if it does.

- Russell


On 2010-07-06 11:53:54, mnick wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/762/
> -----------------------------------------------------------
> 
> (Updated 2010-07-06 11:53:54)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> This is "test 2": "blind transfer with parking timeout" of my GSOC project.
> 
> userA calls userB
> userB transfers userA by "#" -> "700"
> userA gets parked for 5 seconds and returns to userB due to parkingtimeout
> - Test successful -
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs/features.conf PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs/logger.conf PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs2/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs2/logger.conf PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/run-test PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/tests.yaml 461 
> 
> Diff: https://reviewboard.asterisk.org/r/762/diff
> 
> 
> Testing
> -------
> 
> Tested on 1.4, 1.6.0 and 1.6.2 (on a virtual machine, my real one got broken :( ... )
> 
> 
> Thanks,
> 
> mnick
> 
>