[asterisk-dev] [Code Review] IPv6 in Asterisk

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/743/#review2354
-----------------------------------------------------------

Ship it!


This is looking good. I can't find any more problems by just looking at the code. Before I merge the code, I am going to do some documentation tasks, like indicate in the CHANGES file the ability to use IPv6 in chan_sip and adjust the sip.conf.sample file to show the preferred method for setting the port on the bindaddr. Thanks for all your hard work, along with the rest of the team!

- Mark


On 2010-07-08 12:13:07, Simon Perreault wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/743/
> -----------------------------------------------------------
> 
> (Updated 2010-07-08 12:13:07)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Summary
> -------
> 
> This is the port of Asterisk to IPv6.
> 
> 
> This addresses bug 17565.
>     https://issues.asterisk.org/view.php?id=17565
> 
> 
> Diffs
> -----
> 
>   /trunk/addons/chan_ooh323.c 274727 
>   /trunk/apps/app_externalivr.c 274727 
>   /trunk/channels/chan_gtalk.c 274727 
>   /trunk/channels/chan_h323.c 274727 
>   /trunk/channels/chan_iax2.c 274727 
>   /trunk/channels/chan_jingle.c 274727 
>   /trunk/channels/chan_mgcp.c 274727 
>   /trunk/channels/chan_multicast_rtp.c 274727 
>   /trunk/channels/chan_sip.c 274727 
>   /trunk/channels/chan_skinny.c 274727 
>   /trunk/channels/chan_unistim.c 274727 
>   /trunk/channels/sip/dialplan_functions.c 274727 
>   /trunk/channels/sip/include/dialog.h 274727 
>   /trunk/channels/sip/include/globals.h 274727 
>   /trunk/channels/sip/include/reqresp_parser.h 274727 
>   /trunk/channels/sip/include/sip.h 274727 
>   /trunk/channels/sip/reqresp_parser.c 274727 
>   /trunk/include/asterisk/acl.h 274727 
>   /trunk/include/asterisk/config.h 274727 
>   /trunk/include/asterisk/dnsmgr.h 274727 
>   /trunk/include/asterisk/netsock2.h PRE-CREATION 
>   /trunk/include/asterisk/rtp_engine.h 274727 
>   /trunk/include/asterisk/tcptls.h 274727 
>   /trunk/main/acl.c 274727 
>   /trunk/main/app.c 274727 
>   /trunk/main/config.c 274727 
>   /trunk/main/dnsmgr.c 274727 
>   /trunk/main/http.c 274727 
>   /trunk/main/manager.c 274727 
>   /trunk/main/netsock2.c PRE-CREATION 
>   /trunk/main/rtp_engine.c 274727 
>   /trunk/main/tcptls.c 274727 
>   /trunk/res/res_rtp_asterisk.c 274727 
>   /trunk/res/res_rtp_multicast.c 274727 
> 
> Diff: https://reviewboard.asterisk.org/r/743/diff
> 
> 
> Testing
> -------
> 
> See test report on the mantis issue.
> 
> 
> Thanks,
> 
> Simon
> 
>