[asterisk-dev] [Code Review] IPv6 in Asterisk

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/743/#review2350
-----------------------------------------------------------


This is the last issue I can find. Fix this up, and I'll give the code a Ship it!


/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment5203>

    There is some missing logic here regarding the setting of the port for peer->addr. If a peer has has a non-dynamic host set, but has not specified a port, then peer->addr will have a port of 0. It needs to have the default SIP port for the transport type. I've highlighted this section of code because the trunk code on the left is basically what is needed here.


- Mark


On 2010-07-08 12:13:07, Simon Perreault wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/743/
> -----------------------------------------------------------
> 
> (Updated 2010-07-08 12:13:07)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Summary
> -------
> 
> This is the port of Asterisk to IPv6.
> 
> 
> This addresses bug 17565.
>     https://issues.asterisk.org/view.php?id=17565
> 
> 
> Diffs
> -----
> 
>   /trunk/addons/chan_ooh323.c 274727 
>   /trunk/apps/app_externalivr.c 274727 
>   /trunk/channels/chan_gtalk.c 274727 
>   /trunk/channels/chan_h323.c 274727 
>   /trunk/channels/chan_iax2.c 274727 
>   /trunk/channels/chan_jingle.c 274727 
>   /trunk/channels/chan_mgcp.c 274727 
>   /trunk/channels/chan_multicast_rtp.c 274727 
>   /trunk/channels/chan_sip.c 274727 
>   /trunk/channels/chan_skinny.c 274727 
>   /trunk/channels/chan_unistim.c 274727 
>   /trunk/channels/sip/dialplan_functions.c 274727 
>   /trunk/channels/sip/include/dialog.h 274727 
>   /trunk/channels/sip/include/globals.h 274727 
>   /trunk/channels/sip/include/reqresp_parser.h 274727 
>   /trunk/channels/sip/include/sip.h 274727 
>   /trunk/channels/sip/reqresp_parser.c 274727 
>   /trunk/include/asterisk/acl.h 274727 
>   /trunk/include/asterisk/config.h 274727 
>   /trunk/include/asterisk/dnsmgr.h 274727 
>   /trunk/include/asterisk/netsock2.h PRE-CREATION 
>   /trunk/include/asterisk/rtp_engine.h 274727 
>   /trunk/include/asterisk/tcptls.h 274727 
>   /trunk/main/acl.c 274727 
>   /trunk/main/app.c 274727 
>   /trunk/main/config.c 274727 
>   /trunk/main/dnsmgr.c 274727 
>   /trunk/main/http.c 274727 
>   /trunk/main/manager.c 274727 
>   /trunk/main/netsock2.c PRE-CREATION 
>   /trunk/main/rtp_engine.c 274727 
>   /trunk/main/tcptls.c 274727 
>   /trunk/res/res_rtp_asterisk.c 274727 
>   /trunk/res/res_rtp_multicast.c 274727 
> 
> Diff: https://reviewboard.asterisk.org/r/743/diff
> 
> 
> Testing
> -------
> 
> See test report on the mantis issue.
> 
> 
> Thanks,
> 
> Simon
> 
>