[asterisk-dev] [Code Review] GSOC 2010 - Data API providers

Tilghman Lesher tlesher at digium.com
Wed Jul 7 16:02:11 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/757/#review2345
-----------------------------------------------------------

Ship it!


If the only item here was intended, I think this is good to go!


/trunk/main/data.c
<https://reviewboard.asterisk.org/r/757/#comment5198>

    Did you intend to move AST_DATA_POINTER down to the below section?


- Tilghman


On 2010-07-07 15:10:03, Eliel Sardañons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/757/
> -----------------------------------------------------------
> 
> (Updated 2010-07-07 15:10:03)
> 
> 
> Review request for Asterisk Developers and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> Data API providers already implemented for the summer of code 2010 project
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_meetme.c 274685 
>   /trunk/apps/app_queue.c 274685 
>   /trunk/apps/app_voicemail.c 274685 
>   /trunk/channels/chan_agent.c 274685 
>   /trunk/channels/chan_dahdi.c 274685 
>   /trunk/channels/chan_iax2.c 274685 
>   /trunk/channels/chan_sip.c 274685 
>   /trunk/include/asterisk/cdr.h 274685 
>   /trunk/include/asterisk/channel.h 274685 
>   /trunk/include/asterisk/data.h 274685 
>   /trunk/include/asterisk/indications.h 274685 
>   /trunk/main/cdr.c 274685 
>   /trunk/main/channel.c 274685 
>   /trunk/main/data.c 274685 
>   /trunk/main/indications.c 274685 
>   /trunk/main/pbx.c 274685 
>   /trunk/res/res_odbc.c 274685 
> 
> Diff: https://reviewboard.asterisk.org/r/757/diff
> 
> 
> Testing
> -------
> 
> Developer testing.
> 
> 
> Thanks,
> 
> Eliel
> 
>




More information about the asterisk-dev mailing list