[asterisk-dev] [Code Review] Top down test "blind transfer with parking timeout" GSOC 2010

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/762/#review2339
-----------------------------------------------------------


I like this!  Just looking at it from a high level everything appears in order.  You used a common pattern that we have been using with our external tests and I feel confident that design.  My only comment is the timeout of 60 seconds.  Looking at the dialplan, it looked to me like this test should either pass or fail fairly quickly.  If the test generally passes in a few seconds, then a timeout of 60 seconds seems like overkill. 

- David


On 2010-07-06 11:53:54, mnick wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/762/
> -----------------------------------------------------------
> 
> (Updated 2010-07-06 11:53:54)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> This is "test 2": "blind transfer with parking timeout" of my GSOC project.
> 
> userA calls userB
> userB transfers userA by "#" -> "700"
> userA gets parked for 5 seconds and returns to userB due to parkingtimeout
> - Test successful -
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs/features.conf PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs/logger.conf PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs2/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/configs2/logger.conf PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/run-test PRE-CREATION 
>   /asterisk/trunk/tests/blind-transfer-parkingtimeout/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/tests.yaml 461 
> 
> Diff: https://reviewboard.asterisk.org/r/762/diff
> 
> 
> Testing
> -------
> 
> Tested on 1.4, 1.6.0 and 1.6.2 (on a virtual machine, my real one got broken :( ... )
> 
> 
> Thanks,
> 
> mnick
> 
>