[asterisk-dev] [Code Review] GSOC 2010 - Data API providers

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/757/#review2337
-----------------------------------------------------------



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/757/#comment5136>

    You were correct that this was copied correctly; however, I just verified that the code was incorrect.  Fixed in trunk.



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/757/#comment5137>

    You could probably just do this in the initializer for the structure and save a few bytes, i.e.
    
    struct dahdi_versioninfo vi = { .version = "Unknown", .echo_canceller = "Unknown", };



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/757/#comment5138>

    This is a scheduler pointer entry and is thus useless outside of Asterisk.



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/757/#comment5139>

    AST_DATA_SECONDS



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/757/#comment5140>

    Another scheduler entry



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/757/#comment5143>

    All of these should be AST_DATA_MILLISECONDS



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/757/#comment5144>

    AST_DATA_BOOLEAN



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/757/#comment5146>

    Probably should be an enumeration (omit, billing, documentation)



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/757/#comment5145>

    Should be an enumeration (plaintext, md5, rsa)



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/757/#comment5147>

    Possibly an enumeration here.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/757/#comment5150>

    The purpose of this boolean is merely for updating the realtime backend, so it probably doesn't need to be exposed.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/757/#comment5148>

    Enumeration



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/757/#comment5149>

    Enumeration



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/757/#comment5151>

    This is actually an encoded integer, composed of the upper 16 bits, which are the new mailbox messages and the lower 16 bits, which are the old mailbox messages.  Given that that information is available elsewhere, I would suggest dropping this field from the export.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/757/#comment5152>

    This is a set of booleans, that should probably be broken out.  See channels/sip/include/sip.h, in sip_options, for the translations.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/757/#comment5153>

    Scheduler entry.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/757/#comment5154>

    AST_DATA_SECONDS



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/757/#comment5155>

    Another scheduler entry



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/757/#comment5156>

    These are all AST_DATA_MILLISECONDS



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/757/#comment5157>

    Could go for enumeration here.



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/757/#comment5158>

    This field is actually completely unused.



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/757/#comment5159>

    Another enumeration field



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/757/#comment5160>

    Enumeration



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/757/#comment5161>

    Enumeration


- Tilghman


On 2010-07-03 22:17:33, Eliel Sardañons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/757/
> -----------------------------------------------------------
> 
> (Updated 2010-07-03 22:17:33)
> 
> 
> Review request for Asterisk Developers and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> Data API providers already implemented for the summer of code 2010 project
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_meetme.c 273879 
>   /trunk/apps/app_queue.c 273879 
>   /trunk/apps/app_voicemail.c 273879 
>   /trunk/channels/chan_agent.c 273879 
>   /trunk/channels/chan_dahdi.c 273879 
>   /trunk/channels/chan_iax2.c 273879 
>   /trunk/channels/chan_sip.c 273879 
>   /trunk/include/asterisk/cdr.h 273879 
>   /trunk/include/asterisk/channel.h 273879 
>   /trunk/include/asterisk/data.h 273879 
>   /trunk/include/asterisk/indications.h 273879 
>   /trunk/main/cdr.c 273879 
>   /trunk/main/channel.c 273879 
>   /trunk/main/data.c 273879 
>   /trunk/main/indications.c 273879 
>   /trunk/main/pbx.c 273879 
>   /trunk/res/res_odbc.c 273879 
> 
> Diff: https://reviewboard.asterisk.org/r/757/diff
> 
> 
> Testing
> -------
> 
> Developer testing.
> 
> 
> Thanks,
> 
> Eliel
> 
>