[asterisk-dev] [Code Review] Extend pvt->relatedpeer support to INVITES in chan_sip.c

[Philip Prindeville]

On 6/29/10 4:49 AM, Nick Lewis wrote:
>
>    
>> On 2010-06-25 13:55:56, Mark Michelson wrote:
>>      
>>> I can't find anything wrong with it. It's going to be SO convenient to not have to look up a peer every time you need it :)
>>>        
> are you happy to commit it?
>
>
> - Nick
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/629/#review2286
> -----------------------------------------------------------
>    

Asked and answered...  :-(

-Philip


>
> On 2010-05-06 08:57:46, Nick Lewis wrote:
>    
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviewboard.asterisk.org/r/629/
>> -----------------------------------------------------------
>>
>> (Updated 2010-05-06 08:57:46)
>>
>>
>> Review request for Asterisk Developers, Mark Michelson and pprindeville.
>>
>>
>> Summary
>> -------
>>
>> There is an item (relatedpeer) in the pvt structure that references a related (matched) peer structure. This is used during processing of SUBSCRIBE, NOTIFY, and OPTIONS requests and permits peer configuration items to be used without duplicating them in the pvt structure. The attached change extends the availability of the relatedpeer to INVITE processing too.
>>
>>
>> Diffs
>> -----
>>
>>    trunk/channels/chan_sip.c 258227
>>
>> Diff: https://reviewboard.asterisk.org/r/629/diff
>>
>>
>> Testing
>> -------
>>
>> During a incoming call the matched peer appears correctly in a new "Peer" field in the output to the "sip show channels" cli command
>>
>>
>> Thanks,
>>
>> Nick
>>
>>
>>      
>
>