[asterisk-dev] [Code Review] IPv6 in Asterisk

[paul.belanger at polybeacon.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/743/#review2313
-----------------------------------------------------------


Another round of review.  Good work BTW.


/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment5011>

    spacing, and braces.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment5012>

    missing braces



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment5013>

    Missed this last time around, change in behaviour.  Port has been removed. 



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment5014>

    same comment



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment5015>

    same comment



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment5016>

    same comment



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment5017>

    braces since we are here.



/trunk/include/asterisk/acl.h
<https://reviewboard.asterisk.org/r/743/#comment5020>

    blobs



/trunk/include/asterisk/dnsmgr.h
<https://reviewboard.asterisk.org/r/743/#comment5021>

    This comment caught my eye.  I don't think we want to removed it, but would it not be worth the time an effort to start enforcing \version tag in doxygen comments?
    
    A general questions.



/trunk/main/acl.c
<https://reviewboard.asterisk.org/r/743/#comment5022>

    braces



/trunk/main/acl.c
<https://reviewboard.asterisk.org/r/743/#comment5023>

    same



/trunk/main/acl.c
<https://reviewboard.asterisk.org/r/743/#comment5024>

    same



/trunk/main/acl.c
<https://reviewboard.asterisk.org/r/743/#comment5025>

    same



/trunk/main/config.c
<https://reviewboard.asterisk.org/r/743/#comment5026>

    braces



/trunk/main/netsock2.c
<https://reviewboard.asterisk.org/r/743/#comment5027>

    braces



/trunk/main/netsock2.c
<https://reviewboard.asterisk.org/r/743/#comment5028>

    same



/trunk/res/res_rtp_asterisk.c
<https://reviewboard.asterisk.org/r/743/#comment5029>

    braces


- pabelanger


On 2010-07-01 09:30:54, Simon Perreault wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/743/
> -----------------------------------------------------------
> 
> (Updated 2010-07-01 09:30:54)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Summary
> -------
> 
> This is the port of Asterisk to IPv6.
> 
> 
> This addresses bug 17565.
>     https://issues.asterisk.org/view.php?id=17565
> 
> 
> Diffs
> -----
> 
>   /trunk/addons/chan_ooh323.c 273198 
>   /trunk/apps/app_externalivr.c 273198 
>   /trunk/channels/chan_gtalk.c 273198 
>   /trunk/channels/chan_h323.c 273198 
>   /trunk/channels/chan_iax2.c 273198 
>   /trunk/channels/chan_jingle.c 273198 
>   /trunk/channels/chan_mgcp.c 273198 
>   /trunk/channels/chan_multicast_rtp.c 273198 
>   /trunk/channels/chan_sip.c 273198 
>   /trunk/channels/chan_skinny.c 273198 
>   /trunk/channels/chan_unistim.c 273198 
>   /trunk/channels/sip/dialplan_functions.c 273198 
>   /trunk/channels/sip/include/dialog.h 273198 
>   /trunk/channels/sip/include/globals.h 273198 
>   /trunk/channels/sip/include/reqresp_parser.h 273198 
>   /trunk/channels/sip/include/sip.h 273198 
>   /trunk/channels/sip/reqresp_parser.c 273198 
>   /trunk/include/asterisk/acl.h 273198 
>   /trunk/include/asterisk/config.h 273198 
>   /trunk/include/asterisk/dnsmgr.h 273198 
>   /trunk/include/asterisk/netsock2.h PRE-CREATION 
>   /trunk/include/asterisk/rtp_engine.h 273198 
>   /trunk/include/asterisk/tcptls.h 273198 
>   /trunk/main/acl.c 273198 
>   /trunk/main/app.c 273198 
>   /trunk/main/config.c 273198 
>   /trunk/main/dnsmgr.c 273198 
>   /trunk/main/http.c 273198 
>   /trunk/main/manager.c 273198 
>   /trunk/main/netsock2.c PRE-CREATION 
>   /trunk/main/rtp_engine.c 273198 
>   /trunk/main/tcptls.c 273198 
>   /trunk/res/res_rtp_asterisk.c 273198 
>   /trunk/res/res_rtp_multicast.c 273198 
> 
> Diff: https://reviewboard.asterisk.org/r/743/diff
> 
> 
> Testing
> -------
> 
> See test report on the mantis issue.
> 
> 
> Thanks,
> 
> Simon
> 
>