[asterisk-dev] [Code Review] Swap uniqueids during a channel masquerade

[tim.ringenbach at gmail.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/760/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

I feel uniqueid's should be swapped during a channel masquerade, so that the uniqueid follows the outside call leg and not a particular memory allocation on the heap. I believe it has a positive effect on tracking channels through the manager or through cel. It also avoids the weird case of the cdr's uniqueid no longer matching the channel's uniqueid. I posted more details on why I feel this change is needed to the mailing list (see http://lists.digium.com/pipermail/asterisk-dev/2010-June/044754.html).

I included a compat option to restore the original behavior.


Diffs
-----

  http://svn.asterisk.org/svn/asterisk/trunk/configs/asterisk.conf.sample 273565 
  http://svn.asterisk.org/svn/asterisk/trunk/include/asterisk/options.h 273565 
  http://svn.asterisk.org/svn/asterisk/trunk/main/asterisk.c 273565 
  http://svn.asterisk.org/svn/asterisk/trunk/main/channel.c 273565 

Diff: https://reviewboard.asterisk.org/r/760/diff


Testing
-------

Made a couple of calls, did attended transfers through SIP to generate masquerades, watched the manager, the cel log, and 'core show channel xxxx' on the cli to verify it worked as intended.


Thanks,

tim_ringenbach