[asterisk-dev] [Code Review] When setting a soundfile for announce with a length longer then 80 chars a storage overlay happens

Jeff Peeler jpeeler at digium.com
Wed Jan 27 12:43:27 CST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/475/#review1419
-----------------------------------------------------------

Ship it!


This is fine, I'm going to commit it.

- Jeff


On 2010-01-26 10:10:12, syspert wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/475/
> -----------------------------------------------------------
> 
> (Updated 2010-01-26 10:10:12)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Crash in app_queue.
> Changed the length of the announce field from 80 to PATH_MAX
> 
> ref = https://issues.asterisk.org/view.php?id=16488
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_queue.c 235811 
> 
> Diff: https://reviewboard.asterisk.org/r/475/diff
> 
> 
> Testing
> -------
> 
> Tested with long soundfile names.
> 
> 
> Thanks,
> 
> syspert
> 
>




More information about the asterisk-dev mailing list