[asterisk-dev] [Code Review] RFC compliant uri and display-name encode/decode

Olle E. Johansson oej at edvina.net
Wed Jan 27 04:02:48 CST 2010


27 jan 2010 kl. 10.54 skrev Iñaki Baz Castillo:

> 2010/1/26 David Vossel <dvossel at digium.com>:
>> 
>> 
>>> On 2010-01-26 09:08:41, Nick Lewis wrote:
>>>> /trunk/channels/chan_sip.c, line 14697
>>>> <https://reviewboard.asterisk.org/r/469/diff/3/?file=7868#file7868line14697>
>>>> 
>>>>     Add this catch for addr-spec
>>>> 
>>>>     } else if (*input == ':') {
>>>>     /* this is an unbracketed URI rather than a token style display name */
>>>>     *orig_output = '\0';
>>>>     return orig_input;
>> 
>> agreed, this change will go in before I commit this.  thanks
> 
> 
> 
> The following is a valid From header in name-addr format:
> 
>  From: "Alice \"<sip:123 at domain.org>\" and
> Bob"<sip:alice.bob at domain.net>;tag=1234
> 
> where the display-name is:
> 
>  "Alice \"<sip:123 at domain.org>\" and Bob"
> 
> 
> Would Asterisk parse it correctly with this commit?
> 
I guess this is a good test to put in the source :-)

Thanks, Inaki. Any more evil examples?

/O


More information about the asterisk-dev mailing list