[asterisk-dev] [Code Review] Convert test_substitution.c to unit test API

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/474/#review1411
-----------------------------------------------------------

Ship it!


This looks great!  The one comment I have would be how we break out of all the tests on the first failure.  It might be useful to continue testing even though we've encountered a failure and continue to append the error results to the end of the ast_test_error_str as new failures are encountered.  That way we'd know everything that was affected by the failure instead of just the first one.  I don't know how useful that would be though, just an idea.


- David


On 2010-01-23 23:15:19, Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/474/
> -----------------------------------------------------------
> 
> (Updated 2010-01-23 23:15:19)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The main purpose of this patch is to convert the test_substitution module to the unit test API.  I made a few other changes while I was at it, but they are fairly minor.  I removed usage of thread local storage, since this is just test code, an optimization like this seemed unnecessary.  I also did a bit of formatting to reduce line length.
> 
> 
> Diffs
> -----
> 
>   /trunk/tests/test_substitution.c 242519 
> 
> Diff: https://reviewboard.asterisk.org/r/474/diff
> 
> 
> Testing
> -------
> 
> I loaded the module, ran the test, and verified that the tests still all passed.
> 
> 
> Thanks,
> 
> Russell
> 
>