[asterisk-dev] [Code Review] directmediapermit/directmediadeny support to restrict which peers can do directmedia based on ip address

[Olle E Johansson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/467/#review1386
-----------------------------------------------------------


A few small changes that I recommend, but over all seems like a good addition. Especially when we get the named ACL's in place. Thanks!


/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/467/#comment3138>

    trtp = text channel, so change to "Revinvite text to"



/trunk/main/acl.c
<https://reviewboard.asterisk.org/r/467/#comment3139>

    Can change to ast_calloc instead, so that everything will be null


- Olle E


On 2010-01-20 04:05:13, raarts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/467/
> -----------------------------------------------------------
> 
> (Updated 2010-01-20 04:05:13)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> In some networks not all phones are fully routed, i.e. not all phones can ping each other. This patch adds a way to restrict directmedia for certain peers between certain networks. Only implemented for the SIP channel.
> 
> See https://issues.asterisk.org/view.php?id=16645
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 241101 
>   /trunk/configs/sip.conf.sample 241101 
>   /trunk/main/acl.c 241101 
> 
> Diff: https://reviewboard.asterisk.org/r/467/diff
> 
> 
> Testing
> -------
> 
> I tested this in our lab where phones where located on separate VLAN's. The phones that were on the same VLAN talked directly to eachother, and phones that weren't didn't. 
> 
> 
> Thanks,
> 
> raarts
> 
>