[asterisk-dev] [Code Review] directmediapermit/directmediadeny support to restrict which peers can do directmedia based on ip address

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/467/#review1384
-----------------------------------------------------------



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/467/#comment3136>

    I don't understand the purpose of storing off olddirectmediaha if all we are concerned about is freeing it at the end of the function.  If it isn't used anywhere, and the peer's directmediaha is set to NULL, why should we hold on to it?  We do the same thing with oldha.  Maybe I'm just missing something here.


- David


On 2010-01-20 04:05:13, raarts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/467/
> -----------------------------------------------------------
> 
> (Updated 2010-01-20 04:05:13)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> In some networks not all phones are fully routed, i.e. not all phones can ping each other. This patch adds a way to restrict directmedia for certain peers between certain networks. Only implemented for the SIP channel.
> 
> See https://issues.asterisk.org/view.php?id=16645
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 241101 
>   /trunk/configs/sip.conf.sample 241101 
>   /trunk/main/acl.c 241101 
> 
> Diff: https://reviewboard.asterisk.org/r/467/diff
> 
> 
> Testing
> -------
> 
> I tested this in our lab where phones where located on separate VLAN's. The phones that were on the same VLAN talked directly to eachother, and phones that weren't didn't. 
> 
> 
> Thanks,
> 
> raarts
> 
>