[asterisk-dev] [Code Review] High Resolution Call Time for Billsec and Duration

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/461/#review1370
-----------------------------------------------------------



/trunk/cdr/cdr_sqlite.c
<https://reviewboard.asterisk.org/r/461/#comment3114>

    The trick about compile-time options like this is that the creation of the table only occurs once, so if the configuration option is changed later, you'll have a floating point number being inserted into an integer field.
    
    The real rub here is that with SQLite, that's not actually a problem.  You can store any type of value in any type of field, as long as it's not the primary key (which is always an integer and must be such).
    
    A note next to the define would probably be helpful here.  Also, you might want to create the define in a way such that it can be turned on via menuselect (see the top of apps/app_voicemail.c for an example of this).



/trunk/cdr/cdr_sqlite.c
<https://reviewboard.asterisk.org/r/461/#comment3115>

    I'm going to have to insist on the removal of the identation of the preprocessor commands, to be consistent with the formatting of other Asterisk source files.


- Tilghman


On 2010-01-15 05:33:48, Brad Latus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/461/
> -----------------------------------------------------------
> 
> (Updated 2010-01-15 05:33:48)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This allows for the showing of the accurate times for billable time and call duration.
> Adds new flag to CDR function 'f' for the above fields.
> 
> This came about by bug #16559 and I thought i'd take a go at making it happen.
> 
> We can drop a few of the modules for ones we want to depreciate like sql-lite / odbc (in favour of sql-lite3 / adaptive_odbc)
> 
> 
> This addresses bug 16559.
>     https://issues.asterisk.org/view.php?id=16559
> 
> 
> Diffs
> -----
> 
>   /trunk/UPGRADE.txt 238312 
>   /trunk/addons/cdr_mysql.c 238312 
>   /trunk/cdr/cdr_adaptive_odbc.c 238312 
>   /trunk/cdr/cdr_odbc.c 238312 
>   /trunk/cdr/cdr_sqlite.c 238312 
>   /trunk/cdr/cdr_tds.c 238312 
>   /trunk/configs/cdr_custom.conf.sample 238312 
>   /trunk/configs/cdr_odbc.conf.sample 238312 
>   /trunk/configs/cdr_sqlite3_custom.conf.sample 238312 
>   /trunk/configs/cdr_syslog.conf.sample 238312 
>   /trunk/configs/cdr_tds.conf.sample 238312 
>   /trunk/funcs/func_cdr.c 238312 
>   /trunk/CHANGES 238312 
> 
> Diff: https://reviewboard.asterisk.org/r/461/diff
> 
> 
> Testing
> -------
> 
> Compile test only.
> 
> 
> Thanks,
> 
> Brad
> 
>