[asterisk-dev] [Code Review] Provide method for testing GotoIfTime without changing localtime

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/458/#review1354
-----------------------------------------------------------



/trunk/include/asterisk/pbx.h
<https://reviewboard.asterisk.org/r/458/#comment3093>

    Do we really need to create a new function for this?  Since this is going to be trunk only, why couldn't we just expand the old ast_check_timing to take a second argument rather than creating a new addition to the api.  I did a search on all the places ast_check_timing() is used and it didn't look like this would be difficult.



/trunk/main/pbx.c
<https://reviewboard.asterisk.org/r/458/#comment3094>

    why is this necessary?


- David


On 2010-01-11 15:22:43, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/458/
> -----------------------------------------------------------
> 
> (Updated 2010-01-11 15:22:43)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> During the recent holidays, we had discussions on the mailing list about being able to verify whether the dates and times chosen actually performed as expected.  To this end, I have created this method for setting the date and time at which GotoIfTime will be tested, to verify that a particular date and time will take a particular path.
> 
> 
> This addresses bug 16464.
>     https://issues.asterisk.org/view.php?id=16464
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/pbx.h 235421 
>   /trunk/main/pbx.c 235422 
> 
> Diff: https://reviewboard.asterisk.org/r/458/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tilghman
> 
>