[asterisk-dev] [Code Review] add silence gen to wait apps

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/456/
-----------------------------------------------------------

(Updated 2010-01-11 15:38:14.865571)


Review request for Asterisk Developers.


Changes
-------

asterisk.conf's 'transmit_silence' option existed before this patch, but was limited to only generating silence while recording and sending DTMF.  Now enabling the transmit_silence option generates silence during wait times as well.

To achieve this, ast_safe_sleep has been modified to generate silence anytime no other generators are present and transmit_silence is enabled.  Wait apps not using ast_safe_sleep now generate silence when transmit_silence is enabled as well.


Summary
-------

During the wait apps, Wait() WaitUntil() WaitForRing() WaitForSilence(), no audio is generated.  Since no audio is generated audiohooks arn't mixed with anything causing apps like ChanSpy to not work.  This patch adds silence generation to wait apps to create audio.


This addresses bug 16524.
    https://issues.asterisk.org/view.php?id=16524


Diffs (updated)
-----

  /trunk/Makefile 239151 
  /trunk/apps/app_waitforring.c 239151 
  /trunk/apps/app_waitforsilence.c 239151 
  /trunk/main/channel.c 239151 

Diff: https://reviewboard.asterisk.org/r/456/diff


Testing
-------

tested with ChanSpy, whisper now works with channels in Wait() app.


Thanks,

David