[asterisk-dev] [Code Review] add silence gen to wait apps

David Vossel dvossel at digium.com
Fri Jan 8 14:09:40 CST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/456/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

During the wait apps, Wait() WaitUntil() WaitForRing() WaitForSilence(), no audio is generated.  Since no audio is generated audiohooks arn't mixed with anything causing apps like ChanSpy to not work.  This patch adds silence generation to wait apps to create audio.


This addresses bug 16524.
    https://issues.asterisk.org/view.php?id=16524


Diffs
-----

  /trunk/apps/app_waitforring.c 238629 
  /trunk/apps/app_waitforsilence.c 238629 
  /trunk/apps/app_waituntil.c 238629 
  /trunk/main/pbx.c 238629 

Diff: https://reviewboard.asterisk.org/r/456/diff


Testing
-------

tested with ChanSpy, whisper now works with channels in Wait() app.


Thanks,

David




More information about the asterisk-dev mailing list