[asterisk-dev] [Code Review] Build system: allow certain definitions to only be selected explicitly (for UNSUPPORTED_MODULES)

Tilghman Lesher tlesher at digium.com
Fri Feb 26 12:22:04 CST 2010



> On 2010-02-26 11:39:02, Mark Michelson wrote:
> > I might be missing the point of this, but wouldn't setting <defaultenabled>no</defaultenabled> result in the same behavior?

No, the menuselect system currently allows module dependencies to automatically get selected when you attempt to activate a module.  My intent here is to have an option that won't get automatically selected:  you'll need to explicitly mark UNSUPPORTED_MODULES before marking the unsupported modules for build (or the selection will be rejected).


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/506/#review1611
-----------------------------------------------------------


On 2010-02-15 19:59:31, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/506/
> -----------------------------------------------------------
> 
> (Updated 2010-02-15 19:59:31)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Currently, module dependencies are automatically resolved, but in one case, I'd like the dependency to need to be selected only explicitly, because I'd prefer people using unsupported modules to have to consciously make that choice.
> 
> 
> Diffs
> -----
> 
>   /trunk/menuselect.h 715 
>   /trunk/menuselect.c 715 
> 
> Diff: https://reviewboard.asterisk.org/r/506/diff
> 
> 
> Testing
> -------
> 
> Tested, works.
> 
> 
> Thanks,
> 
> Tilghman
> 
>




More information about the asterisk-dev mailing list