[asterisk-dev] [Code Review] Voicemail check cleanup

[Tilghman Lesher]

> On 2010-02-25 17:21:48, Mark Michelson wrote:
> > /trunk/apps/app_voicemail.c, line 11660
> > <https://reviewboard.asterisk.org/r/525/diff/2/?file=8269#file8269line11660>
> >
> >     Though the return of system() is saved here, the value is not inspected.

Fixed.


> On 2010-02-25 17:21:48, Mark Michelson wrote:
> > /trunk/apps/app_voicemail.c, lines 11678-11680
> > <https://reviewboard.asterisk.org/r/525/diff/2/?file=8269#file8269line11678>
> >
> >     It appears that this file does not get deleted when the test is finished.

Fixed.


> On 2010-02-25 17:21:48, Mark Michelson wrote:
> > /trunk/apps/app_voicemail.c, line 11680
> > <https://reviewboard.asterisk.org/r/525/diff/2/?file=8269#file8269line11680>
> >
> >     Though the return of system is saved, the value is never inspected.

Fixed.


> On 2010-02-25 17:21:48, Mark Michelson wrote:
> > /trunk/apps/app_voicemail.c, lines 11683-11685
> > <https://reviewboard.asterisk.org/r/525/diff/2/?file=8269#file8269line11683>
> >
> >     It appears this file does not get deleted when the test finishes.

Fixed (for file storage, the DELETE() does it; for IMAP and ODBC, the DISPOSE() does it).


> On 2010-02-25 17:21:48, Mark Michelson wrote:
> > /trunk/apps/app_voicemail.c, lines 11717-11723
> > <https://reviewboard.asterisk.org/r/525/diff/2/?file=8269#file8269line11717>
> >
> >     All the indices of expected_results in the ast_test_status_update call are off by one.

Fixed.


> On 2010-02-25 17:21:48, Mark Michelson wrote:
> > /trunk/apps/app_voicemail.c, lines 11718-11719
> > <https://reviewboard.asterisk.org/r/525/diff/2/?file=8269#file8269line11718>
> >
> >     Minor nitpick: Any reason the second line is indented further in than the first one?

Merely so that the second lines up under the first.


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/525/#review1600
-----------------------------------------------------------


On 2010-02-24 10:04:33, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/525/
> -----------------------------------------------------------
> 
> (Updated 2010-02-24 10:04:33)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> A few cleanups to fix a few bugs.
> 
> - Urgent voicemails were not attached, because the attachment code looked in the wrong folder.
> - Urgent voicemails were sometimes counted twice when displaying the count of new messages.
> - Backends were inconsistent as to which voicemails each API counted.
> 
> 
> This addresses bugs 15654 and 16448.
>     https://issues.asterisk.org/view.php?id=15654
>     https://issues.asterisk.org/view.php?id=16448
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_voicemail.c 248394 
> 
> Diff: https://reviewboard.asterisk.org/r/525/diff
> 
> 
> Testing
> -------
> 
> Unit test written, tested, and included.
> 
> 
> Thanks,
> 
> Tilghman
> 
>