[asterisk-dev] [Code Review] ACL unit tests

Mark Michelson mmichelson at digium.com
Thu Feb 25 16:53:23 CST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/532/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

There are two unit tests contained here.

1. "Invalid ACL" This attempts to read a bunch of badly formatted ACL entries and add them to a host access rule. The goal of this test is to be sure that all invalid entries are rejected as they should be.

2. "ACL" This sets up four ACLs. One is a permit all, one is a deny all, and the other two have specific rules about which subnets are allowed and which are not. Then a set of test addresses is used to determine whether we would allow those addresses to access us when each ACL is applied. This test, by the way, was what resulted in AST-2010-003's creation.


Diffs
-----

  /trunk/tests/test_acl.c PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/532/diff


Testing
-------

Both tests run and pass.


Thanks,

Mark




More information about the asterisk-dev mailing list