[asterisk-dev] [Code Review] Doxygen for acl.h: 1.4 branch

Mark Michelson mmichelson at digium.com
Thu Feb 25 10:00:31 CST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/528/
-----------------------------------------------------------

(Updated 2010-02-25 10:00:31.728837)


Review request for Asterisk Developers.


Changes
-------

Addressed Leif's suggestions.


Summary
-------

I began to write a unit test for ACLs in Asterisk trunk recently, but I had a hard time because there was absolutely no doxygen at all for the various ACL functions. I decided that a good first step would be to add doxygen to all ACL functions first and then write the unit test.

Note that I have attached here the 1.4 version of the doxygen. The versions for the other branches aren't much different. There is one extra function in Asterisk trunk (ast_str2cos) and the ast_append_ha function has one extra parameter. Other than that, the functions are all the same between all the branches and work the same way.


Diffs (updated)
-----

  /branches/1.4/include/asterisk/acl.h 247166 

Diff: https://reviewboard.asterisk.org/r/528/diff


Testing
-------


Thanks,

Mark




More information about the asterisk-dev mailing list