[asterisk-dev] [Code Review] New dialplan application VMSayname with unit test

[rmudgett at digium.com]

> On 2010-02-24 17:50:06, David Vossel wrote:
> > /trunk/apps/app_voicemail.c, lines 11613-11614
> > <https://reviewboard.asterisk.org/r/530/diff/1/?file=8279#file8279line11613>
> >
> >     you could just combine this into the if statement

All that combining this will do is make the code harder to read.  Yes, I know this is done in a lot of places in the code.  It does not mean that it is a good thing to do.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/530/#review1589
-----------------------------------------------------------


On 2010-02-24 16:19:09, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/530/
> -----------------------------------------------------------
> 
> (Updated 2010-02-24 16:19:09)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds a new application, VMSayName, which plays the greeting for a given voicemail user specified by extension and optionally context. If the greeting does not exist, currently the extension is played back.
> 
> 
> This addresses bug 14973.
>     https://issues.asterisk.org/view.php?id=14973
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_voicemail.c 248659 
> 
> Diff: https://reviewboard.asterisk.org/r/530/diff
> 
> 
> Testing
> -------
> 
> A unit test has been created to test the code paths used for playback in the case when the greeting is present and when it is not. Because the application is really just a wrapper function, the unit test is what needs to be examined more so than anything else.
> 
> 
> Thanks,
> 
> Jeff
> 
>