[asterisk-dev] [Code Review] PITCH_SHIFT dialplan function

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/526/#review1585
-----------------------------------------------------------



/trunk/funcs/func_pitchshift.c
<https://reviewboard.asterisk.org/r/526/#comment3536>

    Casts should be against the variable, not a typename.  This assists if, for example, the variable is ever lengthened to a compatible, but longer type (such as double or long double).



/trunk/funcs/func_pitchshift.c
<https://reviewboard.asterisk.org/r/526/#comment3535>

    There are lots of coding guidelines work that needs to go in here, mainly in regards to spacing.


- Tilghman


On 2010-02-23 21:49:54, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/526/
> -----------------------------------------------------------
> 
> (Updated 2010-02-23 21:49:54)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The PITCH_SHIFT function can be used on a channel to independently modify the pitch of both rx and tx audio streams.  Now you can improve your conference calls by assigning a random pitch effect to everyone entering a meetme room, or just make your day more interesting by making your co-workers sound funny!  There are so many practical uses for this function :)
> 
> 
> Diffs
> -----
> 
>   /trunk/funcs/func_pitchshift.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/526/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David
> 
>