[asterisk-dev] [Code Review] app_directory, support option 'p(n)' as documented with CLI online help, branches 1.6.1 to trunk.

[Alec Davis]

> On 2010-02-23 13:33:20, Mark Michelson wrote:
> > trunk/apps/app_directory.c, line 311
> > <https://reviewboard.asterisk.org/r/481/diff/2/?file=7932#file7932line311>
> >
> >     The value of res appears to be ignored here.

I was in 2 minds as to support pressing '1' or '*' key early, for the impatient caller that knew the menu, otherwise they have to wait out the pause, and then press the selection key.


> On 2010-02-23 13:33:20, Mark Michelson wrote:
> > trunk/apps/app_directory.c, line 293
> > <https://reviewboard.asterisk.org/r/481/diff/2/?file=7932#file7932line293>
> >
> >     Nitpick: make sure to add a space before and after the '=' in opt_pause=0

done.
But didn't fix the space before the ';' in select_item_seq that is unrelated, but I will when I get to ship this.


- Alec


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/481/#review1559
-----------------------------------------------------------


On 2010-02-02 03:25:03, Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/481/
> -----------------------------------------------------------
> 
> (Updated 2010-02-02 03:25:03)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> finish off preliminary work done for initial pause before presenting directory name to caller.
> 
> Currently, 'core show application DIRECTORY' from 1.6.1 through to trunk indicates the 'p(n)' option is available, where in fact there is no code to act on it, other than to populate opts[OPT_ARG_PAUSE].
> 
> 
> This addresses bug 16751.
>     https://issues.asterisk.org/view.php?id=16751
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_directory.c 244325 
> 
> Diff: https://reviewboard.asterisk.org/r/481/diff
> 
> 
> Testing
> -------
> 
> 1.6.1 production server.
> 'p' on it own doesn't introduce delay, as expected.
> 'p(1000)' introduces 1 second delay after intial 3 letters are entered, then presents names individually.
> 'mp(1000)' introduces 1 second delay after intial 3 letters are entered, then presents names as a list.
> 'p(6000)' enforces a maximum of a 3 second delay.
> 
> 
> Thanks,
> 
> Alec
> 
>