[asterisk-dev] [Code Review] replace dahdi_dummy with internal timing

[Shaun Ruffell]

> On 2010-02-19 10:51:43, Shaun Ruffell wrote:
> > What do you think about just completely doing away with dahdi_dummy?  Remove it from the dahdi-tools, remove the "CONFIG_DAHDI_CORE_TIMER" option and just include the code directly in the 2.3 release?
> 
> Tzafrir Cohen wrote:
>     That's basically what this patch is doing.
>     
>     However I prefer not to add such a strong dependency between dahdi-linux and dahdi-tools (or rather: the init script from dahdi-tools. People tend to have older versions of it installed) if not necessary.

Then perhaps leave the module alias (with a comment about why it is there), but still remove all the other references?  Or is there something in an older init script that needs to actually see a dummy span that I'm not aware of?

But, I also don't see any reason not to just do that at a later release if there aren't any problems with making it the default now.


- Shaun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/518/#review1540
-----------------------------------------------------------


On 2010-02-18 11:35:09, Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/518/
> -----------------------------------------------------------
> 
> (Updated 2010-02-18 11:35:09)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> DAHDI internal timing seems to work well.
> 
> This change enables it by default. It also adds the alias 'dahdi_dummy' to the core dahdi module in case it can provide timing, as the dahdi init.d script (and potentially some other user configurations) will try to load it.
> 
> Sadly this will only work if the module dahdi_dummy itself will not get built, and hence the third hunk disables building it.
> 
> Unlike dahdi_dummy this does not add a separate span, and thus has no effect on the configuration of digital DAHDI devices, if added later on.
> 
> 
> Diffs
> -----
> 
>   /linux/trunk/drivers/dahdi/Kbuild 8046 
>   /linux/trunk/drivers/dahdi/dahdi-base.c 8046 
>   /linux/trunk/include/dahdi/dahdi_config.h 8046 
> 
> Diff: https://reviewboard.asterisk.org/r/518/diff
> 
> 
> Testing
> -------
> 
> Built in timing source seems to work well with several systems I've tried. Likewise it seems to work well when adding, removing re-adding etc. a hardware timing source.
> 
> 
> Thanks,
> 
> Tzafrir
> 
>