[asterisk-dev] [Code Review] resilient ast_copy_string()

David Vossel dvossel at digium.com
Thu Feb 18 12:18:33 CST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/519/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

Why not check to see if the src string is NULL in ast_copy_string?  It just seems like a inexpensive check to avoid a silly crash.  If we're going to make our own string copy function why not make it resilient as well?


Diffs
-----

  /trunk/include/asterisk/strings.h 247604 

Diff: https://reviewboard.asterisk.org/r/519/diff


Testing
-------


Thanks,

David




More information about the asterisk-dev mailing list