[asterisk-dev] [Code Review] replace dahdi_dummy with internal timing

[Tzafrir Cohen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/518/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

DAHDI internal timing seems to work well.

This change enables it by default. It also adds the alias 'dahdi_dummy' to the core dahdi module in case it can provide timing, as the dahdi init.d script (and potentially some other user configurations) will try to load it.

Sadly this will only work if the module dahdi_dummy itself will not get built, and hence the third hunk disables building it.

Unlike dahdi_dummy this does not add a separate span, and thus has no effect on the configuration of digital DAHDI devices, if added later on.


Diffs
-----

  /linux/trunk/drivers/dahdi/Kbuild 8046 
  /linux/trunk/drivers/dahdi/dahdi-base.c 8046 
  /linux/trunk/include/dahdi/dahdi_config.h 8046 

Diff: https://reviewboard.asterisk.org/r/518/diff


Testing
-------

Built in timing source seems to work well with several systems I've tried. Likewise it seems to work well when adding, removing re-adding etc. a hardware timing source.


Thanks,

Tzafrir