[asterisk-dev] [Code Review] Unit Test: verify aggregate device state mapping and device to extension state mapping.

[David Vossel]

> On 2010-02-17 11:55:59, Mark Michelson wrote:
> > /trunk/tests/test_devicestate.c, lines 233-235
> > <https://reviewboard.asterisk.org/r/516/diff/1/?file=8152#file8152line233>
> >
> >     I'd recommend, if possible, building on a 32-bit machine just to be sure that using %lu for a size_t doesn't cause a compiler warning. I've gotten in the habit of just casting them to an int and using %d in the format string.
> >     
> >     I think, though, that a size_t is generally a word-sized unsigned quantity, so %lu will probably work. I'd still double-check to be sure though.

good catch, you're right


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/516/#review1532
-----------------------------------------------------------


On 2010-02-17 11:29:02, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/516/
> -----------------------------------------------------------
> 
> (Updated 2010-02-17 11:29:02)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> New unit test to verify aggregate device state mapping and device to extension state mapping.
> 
> 
> Diffs
> -----
> 
>   /trunk/tests/test_devicestate.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/516/diff
> 
> 
> Testing
> -------
> 
> test runs and completes as expected.
> 
> 
> Thanks,
> 
> David
> 
>